chore: add github sponsors on supporters#8531
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
This comment was marked as off-topic.
This comment was marked as off-topic.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (2)
➖ Removed Assets (2)
|
06c283f to
46d49e7
Compare
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds GitHub Sponsors as an additional data source for the “Supporters” section, alongside OpenCollective, by updating the data generator and wiring the UI/docs to the new combined dataset.
Changes:
- Add GitHub Sponsors supporter type and update the Supporters UI to use a unified
urlfield. - Add GitHub GraphQL endpoint constant and implement GitHub Sponsors GraphQL fetching + shuffling in the supporters data generator.
- Update partners/supporters copy to mention GitHub Sponsors.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/site/types/supporters.ts | Introduces a GitHub sponsors supporter type alias. |
| apps/site/pages/en/about/partners.mdx | Updates “Supporters” copy to include GitHub Sponsors. |
| apps/site/next.constants.mjs | Adds GitHub GraphQL API endpoint constant. |
| apps/site/next-data/generators/supportersData.mjs | Expands generator to fetch/merge OpenCollective + GitHub Sponsors and shuffle results. |
| apps/site/components/Common/Supporters/index.tsx | Updates list rendering to use url (and support both sources). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
|
X-posting from Slack... the fine-grained token I generated did not work: I attempted switching the preview to a classic token with no permissions set, which also did not work: Given our security posture for this project is that anyone can submit a PR that will immediately be built on Vercel, anyone could extract this token, so I do not believe it is safe to grant We could attempt using a fine-grained token that has an expiration date, to comply with the org requirement (even though the fine-grained token resource owner is not the org), but that then becomes a yearly maintenance burden for us to ensure it is regenerated before it expires and breaks this feature. I feel like we may be at an impasse here, unless we want to try a classic token with those permissions, but production only, so that this feature will not work in preview deployments? |
|
I have generated a new classic token for @openjs-vercel with just the With that scope applied to the token, https://nodejs-org-git-githubsponsors-openjs.vercel.app/en/about/partners is showing sponsors 🎉 |
|
Cool, so @nodejs/nodejs-website and @nodejs/web-infra, could you please review it? |
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
one clarifying point between a comment and a query
otherwise looks great!
|
@nodejs/nodejs-website any final comments on this? |
I found one data display gap in d32eb79 but there may be more, let's see what the preview holds...mine was only in OC |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d2d73ef. Configure here.



Description
Note that there’s no REST API for GitHub Sponsors, only a GraphQL API. I’m still working on this.
Preview:

Validation
Related Issues
closes #8199
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.